refactor(controls): events→callback props + dynamic component [P6.05]#174
Closed
cesarnml wants to merge 6 commits into
Closed
Conversation
Convert DateRangeSelect, DailyChartControls, DailyGaugeControls, DarkModeToggle
from createEventDispatcher to callback props ($props). Update consumer call-sites
(ActivityChart, TimelineChart, DailyGauge, route pages). Replace
<svelte:component> with {#each}{@const Icon = ...}<Icon /> in DarkModeToggle.
…tate [P6.05] [subagent-review] Missing error boundary in onClick left loading=true on network failure, disabling nav buttons until page reload. setInterval path already had try/catch; aligning.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cesarnml
deleted the
agents/p6-05-events-callback-props-dynamic-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P6.05 Events→callback props + dynamic componentagents/p6-04-standalone-chartscleancompleted at 2026-06-17 03:45 UTCcleancompleted at 2026-06-17 03:49 UTC